linux-kernel - Re: [PATCH] pinctrl: bcm: add OF dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZFqZ-BiWye1J3DJcY-TSMS+EJZbEEHyGTxJm8+Ed1JHA@mail.gmail.com>
Date:	Fri, 22 Jul 2016 16:44:05 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ray Jui <rjui@...adcom.com>,
	Yendapally Reddy Dhananjaya Reddy 
	<yendapally.reddy@...adcom.com>,
	Pramod Kumar <pramodku@...adcom.com>,
	Rob Herring <robh@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: bcm: add OF dependencies

On Fri, Jul 15, 2016 at 10:29 PM, Arnd Bergmann <arnd@...db.de> wrote:

> Building without CONFIG_OF gives us these warnings for the broadcom
> pinctrl drivers:
>
> drivers/pinctrl/bcm/pinctrl-nsp-mux.c:356:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
> drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
>
> The function is only available when CONFIG_OF is set, so we should add
> a Kconfig dependency for both drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: cc4fa83f66e9 ("pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC")

Patch applied.

Yours,
Linus Walleij