linux-kernel - Re: [PATCH] drm/qxl: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Open Source and information security mailing list archives

Message-ID: <CAOw6vbLdgum=PFXv9A7e8sDb-4rLmof_QsYOENwpW37V_UOaCg@mail.gmail.com>
Date:	Fri, 22 Jul 2016 11:25:38 -0400
From:	Sean Paul <seanpaul@...omium.org>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Daniel Vetter <daniel@...ll.ch>,
	David Airlie <airlied@...ux.ie>,
	Julia Lawall <julia.lawall@...6.fr>,
	kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/qxl: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

On Fri, Jul 22, 2016 at 8:22 AM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 22 Jul 2016 14:14:54 +0200
>
> The drm_gem_object_unreference_unlocked() function tests whether
> its argument is NULL and then returns immediately.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied to drm-misc

> ---
>  drivers/gpu/drm/qxl/qxl_display.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
> index ad42968..3aef127 100644
> --- a/drivers/gpu/drm/qxl/qxl_display.c
> +++ b/drivers/gpu/drm/qxl/qxl_display.c
> @@ -468,8 +468,7 @@ void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb)
>  {
>         struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb);
>
> -       if (qxl_fb->obj)
> -               drm_gem_object_unreference_unlocked(qxl_fb->obj);
> +       drm_gem_object_unreference_unlocked(qxl_fb->obj);
>         drm_framebuffer_cleanup(fb);
>         kfree(qxl_fb);
>  }
> --
> 2.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives