linux-kernel - Re: [PATCH] drm/vmwgfx: Delete an unnecessary check before the function call "vfree"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160722153335.GB4008@promb-2n-dhcp144.eng.vmware.com>
Date:	Fri, 22 Jul 2016 08:33:36 -0700
From:	Sinclair Yeh <syeh@...are.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
CC:	<linux-graphics-maintainer@...are.com>,
	<dri-devel@...ts.freedesktop.org>, David Airlie <airlied@...ux.ie>,
	Junwang Zhao <zhjwpku@...il.com>,
	"Thomas Hellstrom" <thellstrom@...are.com>,
	LKML <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] drm/vmwgfx: Delete an unnecessary check before the
 function call "vfree"

Looks good.  Thanks!

Reviewed-by: Sinclair Yeh <syeh@...are.com>

On Fri, Jul 22, 2016 at 01:45:40PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 22 Jul 2016 13:31:00 +0200
> 
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 1a1a87c..dc5beff 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -3625,9 +3625,7 @@ static int vmw_resize_cmd_bounce(struct vmw_sw_context *sw_context,
>  				   (sw_context->cmd_bounce_size >> 1));
>  	}
>  
> -	if (sw_context->cmd_bounce != NULL)
> -		vfree(sw_context->cmd_bounce);
> -
> +	vfree(sw_context->cmd_bounce);
>  	sw_context->cmd_bounce = vmalloc(sw_context->cmd_bounce_size);
>  
>  	if (sw_context->cmd_bounce == NULL) {
> -- 
> 2.9.2
>