linux-kernel - Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2016 11:09:19 -0700
From:	Ray Jui <ray.jui@...adcom.com>
To:	Randy Dunlap <rdunlap@...radead.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Cc:	Ray Jui <rjui@...adcom.com>, bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on
 OF

Hi Randy,

On 7/22/2016 11:06 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
> but COMPILE_TEST is enabled by making the driver depend on OF.
>
> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
>   .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Ray Jui <rjui@...adcom.com>
> Cc: bcm-kernel-feedback-list@...adcom.com
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-gpio@...r.kernel.org
> ---
>  drivers/pinctrl/bcm/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
> +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
> @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
>  config PINCTRL_CYGNUS_MUX
>  	bool "Broadcom Cygnus IOMUX driver"
>  	depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
> +	depends on OF
>  	select PINMUX
>  	select GENERIC_PINCONF
>  	default ARCH_BCM_CYGNUS
>

Thanks, but a fix was already submitted by Arnd and picked up by Linus: 
https://lkml.org/lkml/2016/7/15/649

Ray