linux-kernel - Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <682368c2-5692-5905-7538-36ce2e3d262f@synaptics.com>
Date:	Fri, 22 Jul 2016 11:32:02 -0700
From:	Andrew Duggan <aduggan@...aptics.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Vincent Huang <vincent.huang@...synaptics.com>,
	Nick Dyer <nick@...anahar.org>,
	Chris Healy <cphealy@...il.com>, <devicetree@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm
 gesture parameters to device tree

On 07/22/2016 09:52 AM, Dmitry Torokhov wrote:
> On Wed, Jul 13, 2016 at 11:08:42PM -0700, Andrew Duggan wrote:
>> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
>> ---
>> This version includes Nick's suggestion of adding force to the device tree
>> parameters so make it obvious that these parameters overwrite the
>> default values set in the firware config.
> Why do we want to support overwriting firmware behavior in DT instead of
> flashing new firmware as needed by the product?

If the firmware was configured incorrectly it might just be easier to 
add a device tree entry. This would allow platform owners to make the 
change without having to get Synaptics involved or have access to our 
tools. Customers have also requested using the same module and firmware 
across multiple platforms. Tracking which firmware is on which part 
would create an additional support burden and not all platforms have an 
automated way of checking and updating firmware versions in the event 
that a system is build with a module which has the incorrect firmware.

It is possible that neither of these cases will ever happen and the 
bindings will never be used. I figured it was better to have the options 
available if needed. But, if we want to avoid having tons of device tree 
parameters which are never used then we can leave this patch out and I 
can resubmit it if there is a platform which ends up needing them.

Andrew

> Thanks.
>