linux-kernel - Re: [PATCH RFC] coccinelle: tests: if and else branch should probably not be identical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160722190839.GA15538@osadl.at>
Date:	Fri, 22 Jul 2016 19:08:39 +0000
From:	Nicholas Mc Guire <der.herr@...r.at>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Nicholas Mc Guire <hofrat@...dl.org>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Michal Marek <mmarek@...e.com>, cocci@...teme.lip6.fr,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] coccinelle: tests: if and else branch should
 probably not be identical

On Fri, Jul 22, 2016 at 06:56:47PM +0200, Julia Lawall wrote:
> > +virtual context
> > +virtual org
> > +virtual report
> > +
> > +@...d@
> > +statement S1;
> > +position p;
> > +@@
> > +
> > +<+...
> > +* if@p (...) S1 else S1
> > +...+>
> 
> You don't need the <+... ...+>.  Just put the if by itself.
>

will drop that then - though those would be needed for the cases that 
do this recursively. Will fix it and resend.

thx!
hofrat