linux-kernel - Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Jul 2016 14:01:14 -0400
From:	Oleg Drokin <green@...uxhacker.ru>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lustre Development List <lustre-devel@...ts.lustre.org>,
	Emoly Liu <emoly.liu@...el.com>
Subject: Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'


On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:

> On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote:
>> From: Emoly Liu <emoly.liu@...el.com>
> 
> unrelated trivial notes:
> 
>> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h
> []
>> @@ -33,9 +33,9 @@
>>  
>>  /* The persistent object (i.e. actually stores stuff!) */
>>  #define ECHO_PERSISTENT_OBJID    1ULL
>> -#define ECHO_PERSISTENT_SIZE     ((__u64)(1<<20))
>> +#define ECHO_PERSISTENT_SIZE     ((__u64)(1 << 20))
> 
> This is generally an error-prone pattern as the cast is
> done after the shift.

Hm, indeed.

> Perhaps better is using a specific type
> 
> #define ECHO_PERSISTENT_SIZE		(1ULL << 20)

Yes, I guess this is a better way.

> And lustre seems to use types with unnecessary __ prefixes.

Need to see if this file is included in userspace where the __ is needed.