lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 23 Jul 2016 09:42:21 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-rdma@...r.kernel.org, Dennis Dalessandro <dennis.dalessandro@...el.com>, Doug Ledford <dledford@...hat.com>, Hal Rosenstock <hal.rosenstock@...il.com>, Ira Weiny <ira.weiny@...el.com>, Mike Marciniszyn <mike.marciniszyn@...el.com>, Sean Hefty <sean.hefty@...el.com> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH] IB/hfi1: Delete an unnecessary check before the function call "sc_return_credits" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sat, 23 Jul 2016 08:30:52 +0200 The sc_return_credits() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/infiniband/hw/hfi1/file_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c index c702a00..32c19fa 100644 --- a/drivers/infiniband/hw/hfi1/file_ops.c +++ b/drivers/infiniband/hw/hfi1/file_ops.c @@ -228,7 +228,7 @@ static long hfi1_file_ioctl(struct file *fp, unsigned int cmd, sizeof(struct hfi1_base_info)); break; case HFI1_IOCTL_CREDIT_UPD: - if (uctxt && uctxt->sc) + if (uctxt) sc_return_credits(uctxt->sc); break; -- 2.9.2
Powered by blists - more mailing lists