linux-kernel - Re: is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1607241736480.3265@hadrien>
Date:	Sun, 24 Jul 2016 17:37:56 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	walter harms <wharms@....de>
cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: is_err checking



On Sun, 24 Jul 2016, walter harms wrote:

>
>
> Am 23.07.2016 16:56, schrieb Julia Lawall:
> > Code like the following looks a bit clunky to me:
> >
> > if (IS_ERR(data->clk) && PTR_ERR(data->clk) != -EPROBE_DEFER)
> >
> > Is there any reason not to always use eg
> >
> > data->clk == ERR_PTR(-EPROBE_DEFER)
> >
> > Code of the latter form is a bit more popular.  Perhaps one could want
> > something like:
> >
> > IS_ERR_VALUE(data->clk, -EPROBE_DEFER)
> >
> > but IS_ERR_VALUE is laready used for something else.
> >
>
> note: i do not like hiding behind #defines
>
> did you actually see code like IS_ERR_VALUE(data->clk, -EPROBE_DEFER)
> in the current kernel ?

No, no.  It's the combination of English words I thought would be useful
for expressing the concept.  But it's already used for something else.

julia

> because there is no second argument:
>
> #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
>
> or is this a misunderstanding ?
>
> re,
>  wh
>
> > julia
> > --
> > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
>