linux-kernel - [PATCH] mmc: moxart: fix spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1469378635-15942-1-git-send-email-hofrat@osadl.org>
Date:	Sun, 24 Jul 2016 18:43:55 +0200
From:	Nicholas Mc Guire <hofrat@...dl.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Luis de Bethencourt <luis@...ethencourt.com>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nicholas Mc Guire <hofrat@...dl.org>
Subject: [PATCH] mmc: moxart: fix spin_lock flags type

fix compile warning due to flags being declared long rather than
unsigned long.

Fixes: 1b66e94e6b99 ("mmc: moxart: Add MOXA ART SD/MMC driver")

Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
---
 
 drivers/mmc/host/moxart-mmc.c: In function 'moxart_request':
 drivers/mmc/host/moxart-mmc.c:403:2: warning: comparison of distinct pointer
 types lacks a cast [enabled by default]
 drivers/mmc/host/moxart-mmc.c:427:4: warning: comparison of distinct pointer
 types lacks a cast [enabled by default]
 drivers/mmc/host/moxart-mmc.c:438:4: warning: comparison of distinct pointer
 types lacks a cast [enabled by default]

Compile tested with: moxart_defconfig + ARCH_MULTI_V4=y,
CONFIG_ARCH_MOXART=y, CONFIG_MMC_MOXART=y

Patch is against 4.7.0-rc7 (localversion-next -next-20160724)

 drivers/mmc/host/moxart-mmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
index 2e5c25f..bbad309 100644
--- a/drivers/mmc/host/moxart-mmc.c
+++ b/drivers/mmc/host/moxart-mmc.c
@@ -397,7 +397,8 @@ static void moxart_prepare_data(struct moxart_host *host)
 static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
 {
 	struct moxart_host *host = mmc_priv(mmc);
-	long pio_time, flags;
+	long pio_time;
+	unsigned long flags;
 	u32 status;
 
 	spin_lock_irqsave(&host->lock, flags);
-- 
2.1.4