linux-kernel - Re: [PATCH -v5.1] printk: Add kernel parameter to control writes to /dev/kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201607250034.72IAmpIe%fengguang.wu@intel.com>
Date:	Mon, 25 Jul 2016 00:55:55 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Borislav Petkov <bp@...e.de>
Cc:	kbuild-all@...org, akpm@...ux-foundation.org, bp@...e.de,
	mm-commits@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v5.1] printk: Add kernel parameter to control writes to
 /dev/kmsg

Hi,

[auto build test ERROR on stable/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Borislav-Petkov/printk-Add-kernel-parameter-to-control-writes-to-dev-kmsg/20160725-003035
base:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git master
config: x86_64-randconfig-x012-201630 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   kernel/printk/printk.c: In function 'devkmsg_open':
>> kernel/printk/printk.c:937:2: error: implicit declaration of function 'ratelimit_default_init' [-Werror=implicit-function-declaration]
     ratelimit_default_init(&user->rs);
     ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/printk/printk.c:938:2: error: implicit declaration of function 'ratelimit_set_flags' [-Werror=implicit-function-declaration]
     ratelimit_set_flags(&user->rs, RATELIMIT_MSG_ON_RELEASE);
     ^~~~~~~~~~~~~~~~~~~
>> kernel/printk/printk.c:938:33: error: 'RATELIMIT_MSG_ON_RELEASE' undeclared (first use in this function)
     ratelimit_set_flags(&user->rs, RATELIMIT_MSG_ON_RELEASE);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~
   kernel/printk/printk.c:938:33: note: each undeclared identifier is reported only once for each function it appears in
   kernel/printk/printk.c: In function 'devkmsg_release':
>> kernel/printk/printk.c:958:2: error: implicit declaration of function 'ratelimit_state_exit' [-Werror=implicit-function-declaration]
     ratelimit_state_exit(&user->rs);
     ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/ratelimit_default_init +937 kernel/printk/printk.c

   931		}
   932	
   933		user = kmalloc(sizeof(struct devkmsg_user), GFP_KERNEL);
   934		if (!user)
   935			return -ENOMEM;
   936	
 > 937		ratelimit_default_init(&user->rs);
 > 938		ratelimit_set_flags(&user->rs, RATELIMIT_MSG_ON_RELEASE);
   939	
   940		mutex_init(&user->lock);
   941	
   942		raw_spin_lock_irq(&logbuf_lock);
   943		user->idx = log_first_idx;
   944		user->seq = log_first_seq;
   945		raw_spin_unlock_irq(&logbuf_lock);
   946	
   947		file->private_data = user;
   948		return 0;
   949	}
   950	
   951	static int devkmsg_release(struct inode *inode, struct file *file)
   952	{
   953		struct devkmsg_user *user = file->private_data;
   954	
   955		if (!user)
   956			return 0;
   957	
 > 958		ratelimit_state_exit(&user->rs);
   959	
   960		mutex_destroy(&user->lock);
   961		kfree(user);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (18881 bytes)