linux-kernel - Re: [PATCH v4 5/7] thunderbolt: Networking state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160724223635.GA9516@wunner.de>
Date:	Mon, 25 Jul 2016 00:36:35 +0200
From:	Lukas Wunner <lukas@...ner.de>
To:	Amir Levy <amir.jer.levy@...el.com>
Cc:	andreas.noever@...il.com, gregkh@...uxfoundation.org,
	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	thunderbolt-linux@...el.com, mika.westerberg@...el.com,
	tomas.winkler@...el.com
Subject: Re: [PATCH v4 5/7] thunderbolt: Networking state machine

On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote:
> +	const unique_id_be proto_uuid = APPLE_THUNDERBOLT_IP_PROTOCOL_UUID;
> +
> +	if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid,
> +		   sizeof(proto_uuid)) != 0) {

You may want to use the uuid_be data type provided by <linux/uuid.h>
instead of rolling your own, as well as the helper uuid_be_cmp()
defined ibidem.

Thanks,

Lukas