linux-kernel - drivers/gpu/drm/i915/i915_guc_submission.c:574: error: 'b_ret' may be used uninitialized in this function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201607240814.AuWLAAFg%fengguang.wu@intel.com>
Date:	Sun, 24 Jul 2016 08:33:17 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Mika Kuoppala <mika.kuoppala@...ux.intel.com>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	Daniel Vetter <daniel.vetter@...ll.ch>
Subject: drivers/gpu/drm/i915/i915_guc_submission.c:574: error: 'b_ret' may
 be used uninitialized in this function

Hi,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   107df03203bb66de56e2caec3bde6d22b55480c5
commit: 0a793ad34f137f146119ec4a4a90694ccab77ea3 drm/i915: Force clean compilation with -Werror
date:   3 months ago
config: x86_64-randconfig-v0-07240812 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        git checkout 0a793ad34f137f146119ec4a4a90694ccab77ea3
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All errors (new ones prefixed by >>):

   cc1: warnings being treated as errors
   drivers/gpu/drm/i915/i915_guc_submission.c: In function 'i915_guc_submit':
>> drivers/gpu/drm/i915/i915_guc_submission.c:574: error: 'b_ret' may be used uninitialized in this function
   At top level:
>> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
--
   cc1: warnings being treated as errors
   drivers/gpu/drm/i915/intel_sprite.c: In function 'intel_check_sprite_plane':
   drivers/gpu/drm/i915/intel_sprite.c:763: error: 'src_x' may be used uninitialized in this function
   drivers/gpu/drm/i915/intel_sprite.c:763: error: 'src_y' may be used uninitialized in this function
   drivers/gpu/drm/i915/intel_sprite.c:763: error: 'src_w' may be used uninitialized in this function
   drivers/gpu/drm/i915/intel_sprite.c:763: error: 'src_h' may be used uninitialized in this function
   At top level:
>> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
--
   cc1: warnings being treated as errors
   drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_init_panel_power_sequencer':
   drivers/gpu/drm/i915/intel_dp.c:5101: error: 'pp_div_reg.reg' may be used uninitialized in this function
   drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_init_panel_power_sequencer_registers':
   drivers/gpu/drm/i915/intel_dp.c:5223: error: 'pp_div_reg.reg' may be used uninitialized in this function
   At top level:
>> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
--
   cc1: warnings being treated as errors
   drivers/gpu/drm/i915/intel_tv.c: In function 'intel_tv_detect':
>> drivers/gpu/drm/i915/intel_tv.c:1308: error: 'type' may be used uninitialized in this function
   At top level:
>> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"

vim +/b_ret +574 drivers/gpu/drm/i915/i915_guc_submission.c

44a28b1d Dave Gordon    2015-08-12  558  
44a28b1d Dave Gordon    2015-08-12  559  	return 0;
44a28b1d Dave Gordon    2015-08-12  560  }
44a28b1d Dave Gordon    2015-08-12  561  
44a28b1d Dave Gordon    2015-08-12  562  /**
44a28b1d Dave Gordon    2015-08-12  563   * i915_guc_submit() - Submit commands through GuC
44a28b1d Dave Gordon    2015-08-12  564   * @client:	the guc client where commands will go through
feda33ef Alex Dai       2015-10-19  565   * @rq:		request associated with the commands
44a28b1d Dave Gordon    2015-08-12  566   *
44a28b1d Dave Gordon    2015-08-12  567   * Return:	0 if succeed
44a28b1d Dave Gordon    2015-08-12  568   */
44a28b1d Dave Gordon    2015-08-12  569  int i915_guc_submit(struct i915_guc_client *client,
44a28b1d Dave Gordon    2015-08-12  570  		    struct drm_i915_gem_request *rq)
44a28b1d Dave Gordon    2015-08-12  571  {
44a28b1d Dave Gordon    2015-08-12  572  	struct intel_guc *guc = client->guc;
4a570db5 Tvrtko Ursulin 2016-03-16  573  	unsigned int engine_id = rq->engine->guc_id;
44a28b1d Dave Gordon    2015-08-12 @574  	int q_ret, b_ret;
44a28b1d Dave Gordon    2015-08-12  575  
44a28b1d Dave Gordon    2015-08-12  576  	q_ret = guc_add_workqueue_item(client, rq);
44a28b1d Dave Gordon    2015-08-12  577  	if (q_ret == 0)
44a28b1d Dave Gordon    2015-08-12  578  		b_ret = guc_ring_doorbell(client);
44a28b1d Dave Gordon    2015-08-12  579  
397097b0 Alex Dai       2016-01-23  580  	client->submissions[engine_id] += 1;
44a28b1d Dave Gordon    2015-08-12  581  	if (q_ret) {
44a28b1d Dave Gordon    2015-08-12  582  		client->q_fail += 1;

:::::: The code at line 574 was first introduced by commit
:::::: 44a28b1d36762499de6fd701fcce6814eefe31d7 drm/i915: Implementation of GuC submission client

:::::: TO: Dave Gordon <david.s.gordon@...el.com>
:::::: CC: Daniel Vetter <daniel.vetter@...ll.ch>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (22618 bytes)