lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 Jul 2016 12:12:56 +0530 From: Vinod Koul <vinod.koul@...el.com> To: Sinan Kaya <okaya@...eaurora.org> Cc: "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>, "timur@...eaurora.org" <timur@...eaurora.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "cov@...eaurora.org" <cov@...eaurora.org>, "jcm@...hat.com" <jcm@...hat.com>, "eric.auger@...aro.org" <eric.auger@...aro.org>, "agross@...eaurora.org" <agross@...eaurora.org>, "arnd@...db.de" <arnd@...db.de>, "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "Williams, Dan J" <dan.j.williams@...el.com>, Andy Shevchenko <andy.shevchenko@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 10/10] dmaengine: qcom_hidma: add MSI support for interrupts On Tue, Jul 19, 2016 at 12:09:37AM +0530, Sinan Kaya wrote: > @@ -567,6 +578,98 @@ static int hidma_create_sysfs_entry(struct hidma_dev *dev, char *name, > return device_create_file(dev->ddev.dev, attrs); > } > > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN This can be true on machine with your older HW, so I would be bit more careful here.. > + if (rc) > + dev_warn(&pdev->dev, > + "failed to request MSI irq, falling back to wired IRQ\n"); > + return rc; > +#else > + return -EINVAL; -EINVAL doesnt sound apt here.. > + struct acpi_device *adev = ACPI_COMPANION(dev); > + const char *of_compat; > + int ret; > + > + if (!adev || acpi_disabled) { > + ret = device_property_read_string(dev, "compatible", > + &of_compat); > + if (ret) > + return false; > + > + ret = strcmp(of_compat, "qcom,hidma-1.1"); > + } else { > + ret = strcmp(acpi_device_hid(adev), "QCOM8062"); Okay if you ahve a device ID then why do we need new binding? This device as you said implies the support for MSI interrupts. Thanks -- ~Vinod
Powered by blists - more mailing lists