linux-kernel - Re: [PATCH] cdrom: Delete an unnecessary check before unregister_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2d8fe80-bbbe-0f39-e4c4-d0e68749de39@users.sourceforge.net>
Date:	Sun, 24 Jul 2016 11:45:40 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Cc:	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] cdrom: Delete an unnecessary check before
 unregister_sysctl_table()

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 9 Jul 2015 09:52:24 +0200
> 
> The unregister_sysctl_table() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/cdrom/cdrom.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 5d28a45..e43e84d 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3698,8 +3698,7 @@ static void cdrom_sysctl_register(void)
>  
>  static void cdrom_sysctl_unregister(void)
>  {
> -	if (cdrom_sysctl_header)
> -		unregister_sysctl_table(cdrom_sysctl_header);
> +	unregister_sysctl_table(cdrom_sysctl_header);
>  }
>  
>  #else /* CONFIG_SYSCTL */
> 

How do you think about to integrate this update suggestion
into another source code repository?

Regards,
Markus