linux-kernel - Re: [PATCH 3.12 28/88] netfilter: x_tables: validate targets of jumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160725072706.GC15307@breakpoint.cc>
Date:	Mon, 25 Jul 2016 09:27:06 +0200
From:	Florian Westphal <fw@...len.de>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	Florian Westphal <fw@...len.de>, Jiri Slaby <jslaby@...e.cz>,
	Greg KH <greg@...ah.com>, Jiri Slaby <jirislaby@...il.com>,
	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH 3.12 28/88] netfilter: x_tables: validate targets of jumps

Michal Kubecek <mkubecek@...e.cz> wrote:
> > What lock are you talking about?
> > 
> > The table lock is aquired after the sanity/translation pass.
> 
> I meant xt_compat_lock(AF_INET) (or AF_INET6 or NFPROTO_ARP) which is 
> held for almost all of translate_compat_table().

Ah, true.  Fortunately most installations won't use this.