linux-kernel - Re: [PATCH] SCSI-aic94xx: Delete unnecessary checks before the function call "kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffEmvtLX4rGGn4r+kB9KjMKaPwqNxjk-MfOGTsbukWaTy2A@mail.gmail.com>
Date:	Mon, 25 Jul 2016 10:53:52 +0200
From:	Jinpu Wang <jinpu.wang@...fitbricks.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	linux-scsi@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>,
	Hannes Reinecke <hare@...e.de>,
	"James E. J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] SCSI-aic94xx: Delete unnecessary checks before the
 function call "kmem_cache_destroy"

On Sun, Jul 24, 2016 at 1:51 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
>
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Tue, 17 Nov 2015 08:14:52 +0100
> >
> > The kmem_cache_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the calls is not needed.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > ---
> >  drivers/scsi/aic94xx/aic94xx_init.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
> > index 662b232..ab93049 100644
> > --- a/drivers/scsi/aic94xx/aic94xx_init.c
> > +++ b/drivers/scsi/aic94xx/aic94xx_init.c
> > @@ -660,12 +660,9 @@ Err:
> >
> >  static void asd_destroy_global_caches(void)
> >  {
> > -     if (asd_dma_token_cache)
> > -             kmem_cache_destroy(asd_dma_token_cache);
> > +     kmem_cache_destroy(asd_dma_token_cache);
> >       asd_dma_token_cache = NULL;
> > -
> > -     if (asd_ascb_cache)
> > -             kmem_cache_destroy(asd_ascb_cache);
> > +     kmem_cache_destroy(asd_ascb_cache);
> >       asd_ascb_cache = NULL;
> >  }
> >
> >
>
> How do you think about to integrate this update suggestion
> into another source code repository?
>
> Regards,
> Markus


Looks good to me!
Reviewed-by: Jack Wang <jinpu.wang@...fitbricks.com>

PS: resend to fix mal-format rejection, sorry!
-- 

Mit freundlichen Grüßen,
Best Regards,

Jack Wang