linux-kernel - Re: [PATCH v4] locking/pvqspinlock: Fix double hash race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+Cx8-9CunKWeYmUS+a3oSgtkEO_H8uVwNj-+fyhZvbsxPw@mail.gmail.com>
Date:	Mon, 25 Jul 2016 18:30:43 +0800
From:	Wanpeng Li <kernellwp@...il.com>
To:	Ingo Molnar <mingo@...nel.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kvm <kvm@...r.kernel.org>, Davidlohr Bueso <dave@...olabs.net>,
	Wanpeng Li <wanpeng.li@...mail.com>,
	Waiman Long <Waiman.Long@....com>
Subject: Re: [PATCH v4] locking/pvqspinlock: Fix double hash race

Ping Ingo, Peterz. :)
2016-07-17 4:03 GMT+08:00 Davidlohr Bueso <dave@...olabs.net>:
> On Sat, 16 Jul 2016, Wanpeng Li wrote:
>
>> From: Wanpeng Li <wanpeng.li@...mail.com>
>>
>> When the lock holder vCPU is racing with the queue head vCPU:
>>
>> lock holder vCPU             queue head vCPU
>> =====================        ==================
>>
>> node->locked = 1;
>> <preemption>                 READ_ONCE(node->locked)
>>   ...                       pv_wait_head_or_lock():
>>                               SPIN_THRESHOLD loop;
>>                               pv_hash();
>>                               lock->locked = _Q_SLOW_VAL;
>>                               node->state  = vcpu_hashed;
>> pv_kick_node():
>>  cmpxchg(node->state,
>>     vcpu_halted, vcpu_hashed);
>>  lock->locked = _Q_SLOW_VAL;
>>  pv_hash();
>>
>> With preemption at the right moment, it is possible that both the
>> lock holder and queue head vCPUs can be racing to set node->state
>> which can result in hash entry race. Making sure the state is never
>> set to vcpu_halted will prevent this racing from happening.
>>
>> This patch fix it by setting vcpu_hashed after we did all hash thing.
>>
>> Reviewed-by: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
>> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...nel.org>
>> Cc: Waiman Long <Waiman.Long@....com>
>> Cc: Davidlohr Bueso <dave@...olabs.net>
>> Signed-off-by: Wanpeng Li <wanpeng.li@...mail.com>
>
>
> Reviewed-by: Davidlohr Bueso <dave@...olabs.net>