linux-kernel - Re: staging: ks7010: Rename jump labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160725143933.5f3da07d@endymion>
Date:	Mon, 25 Jul 2016 14:39:33 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org, linux-doc@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: staging: ks7010: Rename jump labels

Hi Markus,

On Thu, 21 Jul 2016 22:11:53 +0200, SF Markus Elfring wrote:
> >> How do you generally think about jump label renaming?
> > 
> > Renaming from "out0:", "out1:" etc to something meaningful, yes.
> 
> I suggest to take another look at such identifiers.
> 
> Would you like to support the renaming of a label like "error_out1"
> (in the function "ks7010_upload_firmware" for example)?

They should be renamed too. Anything using numbers instead of explicit
labels should be updated. I included the reasons in the patch I just
sent, hopefully the documentation is clearer now.

> Will the software evolution be continued also with information from the topic
> "Source code review around jump label usage"?
> https://lkml.org/lkml/2015/12/11/378
> http://article.gmane.org/gmane.linux.kernel/2106190

Personally I see no value in such statistics. Either labels are wrong
(either wrong indentation or wrong name) and should be fixed, or they
are correct and you should not touch them. Whether the same label name
is used somewhere else is irrelevant. Labels are local by nature, so
uniqueness isn't a goal at all, only correctness.

-- 
Jean Delvare
SUSE L3 Support