linux-kernel - Re: [PATCH v4 0/5] vfs: Use dlock list for SB's s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1607250846560.23039@east.gentwo.org>
Date:	Mon, 25 Jul 2016 08:48:25 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Waiman Long <Waiman.Long@....com>
cc:	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.com>,
	Jeff Layton <jlayton@...chiereds.net>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Tejun Heo <tj@...nel.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andi Kleen <andi@...stfloor.org>,
	Dave Chinner <dchinner@...hat.com>,
	Boqun Feng <boqun.feng@...il.com>,
	Scott J Norton <scott.norton@....com>,
	Douglas Hatch <doug.hatch@....com>
Subject: Re: [PATCH v4 0/5] vfs: Use dlock list for SB's s_inodes list

On Fri, 22 Jul 2016, Waiman Long wrote:

>  - Add a new patch to make the percpu head structure cacheline aligned
>    to prevent cacheline contention from disrupting the performance
>    of nearby percpu variables.

It would be better not to use the percpu allocation etc for this.
Given the frequency of off node data access I would say that the data
structure does not qualify as per cpu data. You have per cpu data items
yes but this is not used as per cpu data.