linux-kernel - Re: [PATCH v2] platform: don't return 0 from platform_get_irq[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160725164529.GA7540@kroah.com>
Date:	Mon, 25 Jul 2016 09:45:29 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform: don't return 0 from
 platform_get_irq[_byname]() on error

On Mon, Jul 25, 2016 at 02:55:37PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 7/4/2016 1:04 AM, Sergei Shtylyov wrote:
> 
> > of_irq_get[_byname]() return 0 iff  irq_create_of_mapping() call fails.
> > Returning both  error code and 0 on failure is a sign of a misdesigned API,
> > it makes the failure check unnecessarily complex and error prone. We should
> > rely  on the platform IRQ resource in this case, not return 0,  especially
> > as 0 can be  a valid  IRQ resource too...
> > 
> > Fixes: aff008ad813c ("platform_get_irq: Revert to platform_get_resource if of_irq_get fails")
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> > CC: stable@...r.kernel.org
> 
>    4.7 has been tagged now. Can I count on this patch getting to 4.8? Or at
> least some feedback given? :-/

I'll get to it after 4.8-rc1 is out, but ideally one of the of
developers would look at it, as I have no way to test this...

thanks,

greg k-h