linux-kernel - Re: [PATCH] PCI: xilinx: Modify error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160725174227.GE12484@localhost>
Date:	Mon, 25 Jul 2016 12:42:27 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:	bhelgaas@...gle.com, michal.simek@...inx.com,
	soren.brinkmann@...inx.com, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH] PCI: xilinx: Modify error handling

On Wed, Jun 29, 2016 at 08:48:20PM +0530, Amitoj Kaur Chawla wrote:
> Failure of of_get_next_child returns NULL, not an ERR_PTR. Use
> appropriate error code -ENODEV to be returned on failure instead.
> 
> The Coccinelle semantic patch used to find this issue is as follows:
> @@
> expression E,E1;
> @@
> 
> if (
> *   E == NULL
>    ) { <+... when != E = E1
>         PTR_ERR(E)
>        ...+> }
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  drivers/pci/host/pcie-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
> index 65f0fe0..d76ea8d 100644
> --- a/drivers/pci/host/pcie-xilinx.c
> +++ b/drivers/pci/host/pcie-xilinx.c
> @@ -550,7 +550,7 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_pcie_port *port)
>  	pcie_intc_node = of_get_next_child(node, NULL);
>  	if (!pcie_intc_node) {
>  		dev_err(dev, "No PCIe Intc node found\n");
> -		return PTR_ERR(pcie_intc_node);
> +		return -ENODEV;

This fix is included in the patch posted by Christophe JAILLET
<christophe.jaillet@...adoo.fr>, along with two other similar fixes.
I applied Christophe's patch to pci/host-xilinx for v4.8.

>  	}
>  
>  	port->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html