linux-kernel - Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jul 2016 21:41:41 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Caesar Wang <wxt@...k-chips.com>, dianders@...omium.org
Subject: Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

Am Montag, 25. Juli 2016, 12:39:00 schrieb Guenter Roeck:
> If the ADC is read for the first time, the caller gets a timeout error,
> and the kernel log shows
> 
> read channel() error: -110
> 
> The ADC may be enabled on boot, and needs to be explicitly disabled
> for a read sequence to work (otherwise there is no completion interrupt).
> Disaple it explicitly in the probe function.
> 
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

in my tests I hadn't notices that issue before, but that is likely because the 
bootloaders I had didn't enable the saradc. Anyway, that looks definitly sane, 
so

Reviewed-by: Heiko Stuebner <heiko@...ech.de>