linux-kernel - Re: [PATCH v2 2/2] pcie-designware: add core version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160725201613.GA15939@localhost>
Date:	Mon, 25 Jul 2016 15:16:13 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Joao Pinto <Joao.Pinto@...opsys.com>
Cc:	jingoohan1@...il.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, jszhang@...vell.com,
	CARLOS.PALMINHA@...opsys.com, MiguelFalcao.Sousa@...opsys.com
Subject: Re: [PATCH v2 2/2] pcie-designware: add core version

On Fri, Jul 22, 2016 at 02:29:39PM +0100, Joao Pinto wrote:
> 
> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> ---
> changes v1->v2:
> - Nothing changed. Just to keep up the patch set version.
> 
>  drivers/pci/host/pcie-designware.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 9135725..3e4c600 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -34,6 +34,10 @@
>  #define LINK_WAIT_IATU_MIN		9000
>  #define LINK_WAIT_IATU_MAX		10000
>  
> +/* Core version (available from core 4.70) */
> +#define PCIE_CORE_VERSION		0x8F8
> +#define PCIE_CORE_VERSION_480A		0x3438302a

This should add a use of these symbols at the same time.  There's no
point if adding things that aren't used.

>  /* Synopsys specific PCIE configuration registers */
>  #define PCIE_PORT_LINK_CONTROL		0x710
>  #define PORT_LINK_MODE_MASK		(0x3f << 16)
> -- 
> 1.8.1.5
>