linux-kernel - Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737my1exd.fsf@concordia.ellerman.id.au>
Date:	Mon, 25 Jul 2016 15:10:06 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	chengang@...ndsoft.com.cn, akpm@...ux-foundation.org,
	benh@...nel.crashing.org, paulus@...ba.org
Cc:	dave.hansen@...ux.intel.com, tglx@...utronix.de, mingo@...nel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Chen Gang <chengang@...ndsoft.com.cn>,
	Chen Gang <gang.chen.5i5j@...il.com>
Subject: Re: [PATCH v2] include: mman: Use bool instead of int for the return value of arch_validate_prot

chengang@...ndsoft.com.cn writes:

> From: Chen Gang <chengang@...ndsoft.com.cn>
>
> For pure bool function's return value, bool is a little better more or
> less than int.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/powerpc/include/asm/mman.h | 8 ++++----
>  include/linux/mman.h            | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)

LGTM.

Acked-by: Michael Ellerman <mpe@...erman.id.au>

Andrew do you want to take this or should I?

cheers