linux-kernel - Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160725204516.GB1698@katana>
Date:	Mon, 25 Jul 2016 22:45:16 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	dianders@...omium.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise


> -	else if (resp->i2c_status & EC_I2C_STATUS_ERROR)
> +	else if (resp->i2c_status & EC_I2C_STATUS_NAK)
> +		return -ENXIO;
> +	else if (resp->i2c_status)
>  		return -EREMOTEIO;

Since you mentioned Documentation/i2c/fault-codes already: -EIO?

>  
>  	/* Other side could send us back fewer messages, but not more */
> @@ -223,7 +225,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
>  
>  	result = ec_i2c_parse_response(msg->data, i2c_msgs, &num);
>  	if (result < 0) {
> -		dev_err(dev, "Error parsing EC i2c message %d\n", result);
> +		dev_dbg(dev, "Error parsing EC i2c message %d\n", result);

For me, this message can go entirely, but I'll leave this up to you.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)