linux-kernel - Re: [PATCH] caif-hsi: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160725.213948.1597000820762206692.davem@davemloft.net>
Date:	Mon, 25 Jul 2016 21:39:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhaktipriya96@...il.com
Cc:	dmitry.tarnyagin@...kless.no, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, tj@...nel.org
Subject: Re: [PATCH] caif-hsi: Remove deprecated
 create_singlethread_workqueue

From: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Date: Mon, 25 Jul 2016 18:40:57 +0530

> alloc_workqueue replaces deprecated create_singlethread_workqueue().
> 
> A dedicated workqueue has been used since the workitems are being used
> on a packet tx/rx path. Hence, WQ_MEM_RECLAIM has been set to guarantee
> forward progress under memory pressure.
> 
> An ordered workqueue has been used since workitems &cfhsi->wake_up_work
> and &cfhsi->wake_down_work cannot be run concurrently.
> 
> Calls to flush_workqueue() before destroy_workqueue() have been dropped
> since destroy_workqueue() itself calls drain_workqueue() which flushes
> repeatedly till the workqueue becomes empty.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

Applied.