linux-kernel - Re: [PATCH] s390/perf: fix 'start' address of module's map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160726065433.GA4517@krava>
Date:	Tue, 26 Jul 2016 08:54:33 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Songshan Gong <gongss@...ux.vnet.ibm.com>
Cc:	acme@...nel.org, jolsa@...nel.org, dsahern@...il.com,
	linux-kernel@...r.kernel.org, borntraeger@...ibm.com
Subject: Re: [PATCH] s390/perf: fix 'start' address of module's map

On Fri, Jul 22, 2016 at 10:47:34AM +0800, Songshan Gong wrote:
> Has the patch been accepted by upstream?
> 
> 在 7/21/2016 11:10 AM, Song Shan Gong 写道:
> > At preset, when creating module's map, perf gets 'start' address by parsing
> > '/proc/modules', but it's module base address, isn't the start address of
> > '.text' section. In most archs, it's OK. But for s390, it places 'GOT' and
> > 'PLT' relocations before '.text' section. So there exists an offset between
> > module base address and '.text' section, which will incur wrong symbol
> > resolution for modules.
> > 
> > Fix this bug by getting 'start' address of module's map from parsing
> > '/sys/module/[module name]/sections/.text', not from '/proc/modules'.
> > 
> > Signed-off-by: Song Shan Gong <gongss@...ux.vnet.ibm.com>
> > Acked-by: Jiri Olsa <jolsa@...nel.org>

I think it's good to go, Arnaldo, could you please take this one?

thanks,
jirka