linux-kernel - Re: [STLinux Kernel] [PATCH 1/1] drm/sti: use new Reset API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOw6vbLCQG6CJ2adntdSDsV2djmOKv0hS3Ks6niNEanXOR1u9w@mail.gmail.com>
Date:	Tue, 26 Jul 2016 10:27:09 -0400
From:	Sean Paul <seanpaul@...omium.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Peter Griffin <peter.griffin@...aro.org>,
	Linux ARM Kernel <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kernel@...inux.com, Dave Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	benjamin.gaignard@...aro.org
Subject: Re: [STLinux Kernel] [PATCH 1/1] drm/sti: use new Reset API

On Mon, Jul 25, 2016 at 6:40 AM, Lee Jones <lee.jones@...aro.org> wrote:
> On Mon, 25 Jul 2016, Peter Griffin wrote:
>> On Mon, 25 Jul 2016, Lee Jones wrote:
>>
>> > Since 0b52297f228 ("reset: Add support for shared reset controls") the
>> > new Reset API now demands consumers choose either an *_exclusive or a
>> > *_shared line when requesting reset lines.
>> >
>> > This issue was found when running a kernel containing the aforementioned
>> > patch  which includes an informitive WARN().  It implies that one or
>> > more used reset lines are in fact shared.  This is why we're using the
>> > *_shared variant.
>> >
>> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
>> > ---
>> >  drivers/gpu/drm/sti/sti_compositor.c | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Your missing a changelog on the v2 version.
>
> This isn't really a v2, hence the lack if [PATCH vX] increment.
>
> This is v1 with a more verbose changelog.
>
>> Apart from that:
>>  Acked-by: Peter Griffin <peter.griffin@...aro.org>
>
> Ta.

Applied to drm-misc, thanks for revising.

>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog