linux-kernel - Re: [PATCH] hwmon: iio_hwmon: fix memory leak in name attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160726155052.GB30628@roeck-us.net>
Date:	Tue, 26 Jul 2016 08:50:52 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:	jdelvare@...e.com, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, antoine.tenart@...e-electrons.com
Subject: Re: [PATCH] hwmon: iio_hwmon: fix memory leak in name attribute

On Tue, Jul 26, 2016 at 09:47:09AM +0200, Quentin Schulz wrote:
> The "name" variable's memory is now freed when the device is destructed
> thanks to devm function.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
> Reported-by: Guenter Roeck <linux@...ck-us.net>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/iio_hwmon.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/hwmon/iio_hwmon.c b/drivers/hwmon/iio_hwmon.c
> index 0a00bfb..777f2b5 100644
> --- a/drivers/hwmon/iio_hwmon.c
> +++ b/drivers/hwmon/iio_hwmon.c
> @@ -110,24 +110,24 @@ static int iio_hwmon_probe(struct platform_device *pdev)
>  
>  		switch (type) {
>  		case IIO_VOLTAGE:
> -			a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
> -							  "in%d_input",
> -							  in_i++);
> +			a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
> +							       "in%d_input",
> +							       in_i++);
>  			break;
>  		case IIO_TEMP:
> -			a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
> -							  "temp%d_input",
> -							  temp_i++);
> +			a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
> +							       "temp%d_input",
> +							       temp_i++);
>  			break;
>  		case IIO_CURRENT:
> -			a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
> -							  "curr%d_input",
> -							  curr_i++);
> +			a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
> +							       "curr%d_input",
> +							       curr_i++);
>  			break;
>  		case IIO_HUMIDITYRELATIVE:
> -			a->dev_attr.attr.name = kasprintf(GFP_KERNEL,
> -							  "humidity%d_input",
> -							  humidity_i++);
> +			a->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
> +							       "humidity%d_input",
> +							       humidity_i++);
>  			break;
>  		default:
>  			ret = -EINVAL;
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html