linux-kernel - Re: [PATCH] cfag12864b: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160726170123.GW19588@mtj.duckdns.org>
Date:	Tue, 26 Jul 2016 13:01:23 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cfag12864b: Remove deprecated
 create_singlethread_workqueue

On Tue, Jul 26, 2016 at 10:23:00PM +0530, Bhaktipriya Shridhar wrote:
> @@ -257,7 +256,6 @@ void cfag12864b_disable(void)
>  	if (cfag12864b_updating) {
>  		cfag12864b_updating = 0;
>  		cancel_delayed_work(&cfag12864b_work);
> -		flush_workqueue(cfag12864b_workqueue);

It should be converted to cancel_delayed_work_sync(); otherwise,
nothing guarantees that the work item is finished.

Thanks.

-- 
tejun