linux-kernel - Re: [PATCH BUGFIX V4] block: add missing group association in bio-cloning functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2016 01:01:44 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Paolo Valente <paolo.valente@...aro.org>
Cc:	kbuild-all@...org, Jens Axboe <axboe@...nel.dk>,
	Tejun Heo <tj@...nel.org>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, ulf.hansson@...aro.org,
	linus.walleij@...aro.org, broonie@...nel.org,
	stable@...r.kernel.org, jmoyer@...hat.com,
	Nikolay Borisov <kernel@...p.com>,
	Paolo Valente <paolo.valente@...aro.org>
Subject: Re: [PATCH BUGFIX V4] block: add missing group association in
 bio-cloning functions

Hi,

[auto build test WARNING on block/for-next]
[also build test WARNING on v4.7 next-20160726]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paolo-Valente/block-add-missing-group-association-in-bio-cloning-functions/20160727-005044
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-x015-201630 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from block/bio.c:20:0:
   include/linux/bio.h: In function 'bio_clone_blkcg_association':
>> include/linux/bio.h:480:30: warning: 'return' with a value, in function returning void
       struct bio *src) { return 0; }
                                 ^
   include/linux/bio.h:479:20: note: declared here
    static inline void bio_clone_blkcg_association(struct bio *dst,
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/return +480 include/linux/bio.h

   464	void zero_fill_bio(struct bio *bio);
   465	extern struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *);
   466	extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int);
   467	extern unsigned int bvec_nr_vecs(unsigned short idx);
   468	
   469	#ifdef CONFIG_BLK_CGROUP
   470	int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css);
   471	int bio_associate_current(struct bio *bio);
   472	void bio_disassociate_task(struct bio *bio);
   473	void bio_clone_blkcg_association(struct bio *dst, struct bio *src);
   474	#else	/* CONFIG_BLK_CGROUP */
   475	static inline int bio_associate_blkcg(struct bio *bio,
   476				struct cgroup_subsys_state *blkcg_css) { return 0; }
   477	static inline int bio_associate_current(struct bio *bio) { return -ENOENT; }
   478	static inline void bio_disassociate_task(struct bio *bio) { }
   479	static inline void bio_clone_blkcg_association(struct bio *dst,
 > 480				struct bio *src) { return 0; }
   481	#endif	/* CONFIG_BLK_CGROUP */
   482	
   483	#ifdef CONFIG_HIGHMEM
   484	/*
   485	 * remember never ever reenable interrupts between a bvec_kmap_irq and
   486	 * bvec_kunmap_irq!
   487	 */
   488	static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (26155 bytes)