linux-kernel - Re: [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160726174331.GN6746@brain>
Date:	Tue, 26 Jul 2016 18:43:31 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Douglas <alanjhd@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Improve 'bare use of' signed/unsigned types
 warning

On Tue, Jul 26, 2016 at 03:40:21AM -0700, Joe Perches wrote:
> Fix false positive warning of identifiers ending in signed with an =
> assignment of WARNING: Prefer 'signed int' to bare use of 'signed'.
> 
> Reported-by: Alan Douglas <alanjhd@...il.com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 77915e0..1d5b09d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3347,7 +3347,7 @@ sub process {
>  		next if ($line =~ /^[^\+]/);
>  
>  # check for declarations of signed or unsigned without int
> -		while ($line =~ m{($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
> +		while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
>  			my $type = $1;
>  			my $var = $2;
>  			$var = "" if (!defined $var);
> -- 
> 2.8.0.rc4.16.g56331f8
> 

Derp, yes.

Acked-by: Andy Whitcroft <apw@...onical.com>

-apw