lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jul 2016 22:11:00 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Oleg Drokin <oleg.drokin@...el.com> Cc: devel@...verdev.osuosl.org, lustre-devel@...ts.lustre.org, Andreas Dilger <andreas.dilger@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>, Bhumika Goyal <bhumirks@...il.com> Subject: Re: staging: lustre: Optimize error handling in class_register_type() > NAK. > when you do this, the next statement below breaks: I wonder about this conclusion. >> type = kzalloc(sizeof(*type), GFP_NOFS); >> if (!type) >> - return rc; >> + return -ENOMEM; >> >> type->typ_dt_ops = kzalloc(sizeof(*type->typ_dt_ops), GFP_NOFS); >> if (!type->typ_dt_ops) { > … > goto failed; > > failed: > … > return rc; > > So we are now returning an unitialized rc, did you get a gcc warning about it when compiling? I do not get such an impression if my corresponding update suggestion "[PATCH 04/12] staging: lustre: Split a condition check in class_register_type()" will be considered for this use case once more. https://lkml.org/lkml/2016/7/26/462 https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1197227.html Regards, Markus
Powered by blists - more mailing lists