linux-kernel - RE: [kernel-hardening] [PATCH] [RFC] Introduce mmap randomization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <476DC76E7D1DF2438D32BFADF679FC560125F2D5@ORSMSX103.amr.corp.intel.com>
Date:	Tue, 26 Jul 2016 20:17:04 +0000
From:	"Roberts, William C" <william.c.roberts@...el.com>
To:	Rik van Riel <riel@...hat.com>,
	"kernel-hardening@...ts.openwall.com" 
	<kernel-hardening@...ts.openwall.com>,
	"jason@...edaemon.net" <jason@...edaemon.net>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC:	"keescook@...omium.org" <keescook@...omium.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"nnk@...gle.com" <nnk@...gle.com>,
	"jeffv@...gle.com" <jeffv@...gle.com>,
	"salyzyn@...roid.com" <salyzyn@...roid.com>,
	"dcashman@...roid.com" <dcashman@...roid.com>
Subject: RE: [kernel-hardening] [PATCH] [RFC] Introduce mmap randomization

> -----Original Message-----
> From: Rik van Riel [mailto:riel@...hat.com]
> Sent: Tuesday, July 26, 2016 1:12 PM
> To: kernel-hardening@...ts.openwall.com; jason@...edaemon.net; linux- 
> mm@...r.kernel.org; linux-kernel@...r.kernel.org; akpm@...ux- 
> foundation.org
> Cc: keescook@...omium.org; gregkh@...uxfoundation.org; nnk@...gle.com; 
> jeffv@...gle.com; salyzyn@...roid.com; dcashman@...roid.com; Roberts, 
> William C <william.c.roberts@...el.com>
> Subject: Re: [kernel-hardening] [PATCH] [RFC] Introduce mmap 
> randomization
> 
> On Tue, 2016-07-26 at 11:22 -0700, william.c.roberts@...el.com wrote:
> > From: William Roberts <william.c.roberts@...el.com>
> >
> > This patch introduces the ability randomize mmap locations where the 
> > address is not requested, for instance when ld is allocating pages 
> > for shared libraries. It chooses to randomize based on the current 
> > personality for ASLR.
> >
> > Currently, allocations are done sequentially within unmapped address 
> > space gaps. This may happen top down or bottom up depending on scheme.
> >
> > For instance these mmap calls produce contiguous mappings:
> > int size = getpagesize();
> > mmap(NULL, size, flags, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
> > 0x40026000
> > mmap(NULL, size, flags, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
> > 0x40027000
> >
> > Note no gap between.
> >
> > After patches:
> > int size = getpagesize();
> > mmap(NULL, size, flags, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
> > 0x400b4000
> > mmap(NULL, size, flags, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
> > 0x40055000
> >
> > Note gap between.
> 
> I suspect this randomization will be more useful for file mappings 
> than for anonymous mappings.
> 
> I don't know whether there are downsides to creating more anonymous 
> VMAs than we have to, with malloc libraries that may perform various 
> kinds of tricks with mmap for their own performance reasons.
> 
> Does anyone have convincing reasons why mmap randomization should do 
> both file and anon, or whether it should do just file mappings?

Throwing this out there, but If you're mmap'ing buffers at known offsets in the
program then folks know where to write/modify.

Jason Cooper mentioned using a KConfig around this (amongst other things) which perhaps
Controlling this at a better granularity would be beneficial.

> 
> --
> All rights reversed