linux-kernel - Re: [alsa-devel] [PATCH v2] clkdev: add devm_of_clk_get()

Open Source and information security mailing list archives

Message-ID: <87a8h3di61.wl%kuninori.morimoto.gx@renesas.com>
Date:	Wed, 27 Jul 2016 00:51:27 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Michael Turquette <mturquette@...libre.com>,
	Rob Herring <robh@...nel.org>,
	Russell King <linux@...linux.org.uk>,
	Mark Brown <broonie@...nel.org>
CC:	Linux-ALSA <alsa-devel@...a-project.org>,
	Linux-DT <devicetree@...r.kernel.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	<linux-clk@...r.kernel.org>,
	Linux-ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [alsa-devel] [PATCH v2] clkdev: add devm_of_clk_get()

Hi Rob, Michael, Russell
Cc Rob

What is the conclusion of this patch ?
We shouldn't add devm_of_clk_get() ? or I can continue ?

> Thank you for your feedback
> 
> > > struct clk *clk_get(struct device *dev, const char *con_id)
> > > {
> > >         ...
> > >         if (dev) {
> > >                 clk = __of_clk_get_by_name(dev->of_node, dev_id, con_id);
> > >                                            ~~~~~~~~~~~~
> > >                 ...
> > >         }
> > > }
> > > 
> > > I would like to select specific device_node.
> > 
> > Do you have access to the struct device that you want to target? Can you
> > pass that device into either clk_get or devm_clk_get?
> 
> If my understanding was correct, I think I can't.
> In below case, "sound_soc" has its *dev, but "cpu" and "codec" doesn't
> have *dev, it has node only. Thus, we are using of_clk_get() for these now.
> 
> 	clk = of_clk_get(cpu, xxx);
> 	clk = of_clk_get(codec, xxx);
> 
> 	sound_soc {
> 		...
> 		cpu {
> 			...
> =>			clocks = <&xxx>;
> 		};
> 		codec {
> 			...
> =>			clocks = <&xxx>;
> 		};
> 	};
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives