linux-kernel - Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d2a3059-2198-521a-e102-891c7b393f58@huawei.com>
Date:	Wed, 27 Jul 2016 14:56:55 +0800
From:	Kefeng Wang <wangkefeng.wang@...wei.com>
To:	Max Filippov <jcmvbkbc@...il.com>, Rob Herring <robh@...nel.org>
CC:	Chris Zankel <chris@...kel.net>, <linux-kernel@...r.kernel.org>,
	<linux-xtensa@...ux-xtensa.org>, Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary
 of_platform_populate with default match table"



On 2016/7/27 2:50, Max Filippov wrote:
> On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
>> This partially reverts commit 69d99e6c0d62 keeping only the main
>> purpose of the original commit which is the removal of
>> of_platform_populate() call. The moving of of_clk_init() caused changes
>> in the initialization order breaking booting.
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
>> Cc: Kefeng Wang <wangkefeng.wang@...wei.com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Max Filippov <jcmvbkbc@...il.com>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>> This is on top of Guenter's build fix. Please test and I'll apply. I 

Hi all,

Sorry about the issue introduced by me, will be more careful,
and thanks Rob and Guenter to fix them.

BRs,
Kefeng


> 
> Tested-by: Max Filippov <jcmvbkbc@...il.com>
> 
>> tried briefly running under QEMU, but didn't have success. If anyone has 
>> up to date instructions that would be helpful as using these[1] didn't 
>> seem to work.
> 
> I think they're up to date. Another thing that need to be done right is
> the toolchain: it must match the configured CPU core. Please refer to
>   http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
> for more details.
> 
>>
>> [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU
>>
>>  arch/xtensa/kernel/setup.c | 9 +++++++++
>>  arch/xtensa/kernel/time.c  | 2 --
>>  2 files changed, 9 insertions(+), 2 deletions(-)
>