linux-kernel - Re: [PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57986CF3.4070602@parrot.com>
Date:	Wed, 27 Jul 2016 10:12:35 +0200
From:	Gregor Boirie <gregor.boirie@...rot.com>
To:	Alison Schofield <amsfield22@...il.com>, <jic23@...nel.org>
CC:	<knaack.h@....de>, <lars@...afoo.de>, <pmeerw@...erw.net>,
	<linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools: iio: iio_generic_buffer: initialize channel array
 pointer


On 07/27/2016 05:17 AM, Alison Schofield wrote:
> Uninitialized channel pointer causes segmentation fault when we
> call free(channel) during cleanup() with no channels initialized.
> This happens when you exit early for usage errors.  Initialize
> the pointer to NULL when it is declared.
>
> Signed-off-by: Alison Schofield <amsfield22@...il.com>
> Cc: Daniel Baluta <daniel.baluta@...il.com>
> ---
>   tools/iio/iio_generic_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
> index 0e8a1f7..ae68bf0 100644
> --- a/tools/iio/iio_generic_buffer.c
> +++ b/tools/iio/iio_generic_buffer.c
> @@ -348,7 +348,7 @@ int main(int argc, char **argv)
>   	int notrigger = 0;
>   	char *dummy;
>   
> -	struct iio_channel_info *channels;
> +	struct iio_channel_info *channels = NULL;
>   
>   	register_cleanup();
>   
Tested-by: Gregor Boirie <gregor.boirie@...rot.com>

greg.