linux-kernel - Re: [PATCH -v2 1/2] x86/asm: Add __PAGE_OFFSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160727090516.GC30204@gmail.com>
Date:	Wed, 27 Jul 2016 11:05:16 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...e.de>
Cc:	Kees Cook <keescook@...omium.org>,
	Thomas Garnier <thgarnie@...gle.com>,
	Nicolai Stange <nicstange@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH -v2 1/2] x86/asm: Add __PAGE_OFFSET_BASE define on 32-bit


* Borislav Petkov <bp@...e.de> wrote:

> From: Borislav Petkov <bp@...e.de>
> 
> ... in order to avoid ifdeffery in code computing the ASLR randomization
> offset.
> 
> Suggested-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  arch/x86/include/asm/page_32_types.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/page_32_types.h b/arch/x86/include/asm/page_32_types.h
> index 3a52ee0e726d..3bae4969ac65 100644
> --- a/arch/x86/include/asm/page_32_types.h
> +++ b/arch/x86/include/asm/page_32_types.h
> @@ -13,7 +13,8 @@
>   * If you want more physical memory than this then see the CONFIG_HIGHMEM4G
>   * and CONFIG_HIGHMEM64G options in the kernel configuration.
>   */
> -#define __PAGE_OFFSET		_AC(CONFIG_PAGE_OFFSET, UL)
> +#define __PAGE_OFFSET_BASE	_AC(CONFIG_PAGE_OFFSET, UL)
> +#define __PAGE_OFFSET		__PAGE_OFFSET_BASE

Could you please send a delta patch for this? I've already applied the original 
fix, with a few minor edits.

Thanks,

	Ingo