linux-kernel - RE: [PATCH] qed: Add and use specific logging functions to reduce object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR11MB0088AF8C3194FE63E5200054970F0@CO2PR11MB0088.namprd11.prod.outlook.com>
Date:	Wed, 27 Jul 2016 07:32:18 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Joe Perches <joe@...ches.com>,
	Ariel Elior <Ariel.Elior@...gic.com>,
	Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@...gic.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH] qed: Add and use specific logging functions to reduce
 object size

> > Current DP_ macros generate a lot of code.
> > Using functions with vsprintf extension %pV helps reduce that size.
> 
> Yuval, I used the same KERN_<LEVEL> output types, but it is unusual
> that DP_INFO outputs at KERN_NOTICE.
> 
> Was that a copy/paste defect or should it be emitted at KERN_INFO and
> DP_VERBOSE be emitted at KERN_DEBUG?

I agree it's a bit odd, but it's actually by design - 
as none of these prints would ever be reached unless user explicitly enable
them [ethtool/module param], the assumption is that NOTICE is good
enough, i.e., it will prevent the need for doing additional configuration of
logging levels by the user.