linux-kernel - Re: [PATCH] KEYS: x86_64 needs to use compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2016 13:21:48 +0200
From:	Stephan Mueller <smueller@...onox.de>
To:	David Howells <dhowells@...hat.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, linux-security-module@...r.kernel.org,
	keyrings@...r.kernel.org
Subject: Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace

Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells:

Hi David,

> x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
> the issue.
> 
> Reported-by: Stephan Mueller <smueller@...onox.de>
> Signed-off-by: David Howells <dhowells@...hat.com>

Tested-by: Stephan Mueller <smueller@...onox.de>

> cc: stable@...r.kernel.org
> ---
> 
>  arch/x86/entry/syscalls/syscall_32.tbl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl
> b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea
> 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -294,7 +294,7 @@
>  # 285 sys_setaltroot
>  286	i386	add_key			sys_add_key
>  287	i386	request_key		sys_request_key
> -288	i386	keyctl			sys_keyctl
> +288	i386	keyctl			sys_keyctl			compat_sys_keyctl
>  289	i386	ioprio_set		sys_ioprio_set
>  290	i386	ioprio_get		sys_ioprio_get
>  291	i386	inotify_init		sys_inotify_init



Ciao
Stephan