linux-kernel - Re: [RESEND PATCH V3] fs: befs: Insert NULL inode to dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5798D2CE.6000509@osg.samsung.com>
Date:	Wed, 27 Jul 2016 16:27:10 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Salah Triki <salah.triki@...il.com>, viro@...IV.linux.org.uk
CC:	akpm@...ux-foundation.org, mhocko@...e.com, vdavydov@...tuozzo.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH V3] fs: befs: Insert NULL inode to dentry

On 27/07/16 03:35, Salah Triki wrote:
> As VFS expects, lookup inserts NULL inode to dentry when the named inode
> does not exist.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/befs/linuxvfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index c734f21..2fea87b 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -184,6 +184,7 @@ befs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
>  
>  	if (ret == BEFS_BT_NOT_FOUND) {
>  		befs_debug(sb, "<--- %s %pd not found", __func__, dentry);
> +		d_add(dentry, NULL);
>  		return ERR_PTR(-ENOENT);
>  
>  	} else if (ret != BEFS_OK || offset == 0) {
> 

Hi,

The expectation Salah is mentioning can be seen in
Documentation/filesystems/vfs.txt:383
"If the named inode does not exist a NULL inode should be inserted
into the dentry (this is called a negative dentry)."

Acked-by: Luis de Bethencourt <luisbg@....samsung.com>

I have applied this patch into [0]:
https://github.com/luisbg/linux-befs/tree/befs-next

Thanks,
Luis





[0] reason for the git branch: https://lkml.org/lkml/2016/7/26/533