linux-kernel - Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201607271805.57123@pali>
Date:	Wed, 27 Jul 2016 18:05:57 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Mario_Limonciello@...l.com
Cc:	dvhart@...radead.org, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s

On Wednesday 27 July 2016 17:55:09 Mario_Limonciello@...l.com wrote:
> > Hi! I'm not sure if KEY_PROG1/2/3 are good names here as we already
> > use
> >
> >those for other actions (see bios_to_linux_keycode). Also there is:
> I had missed this, do you have some recommendations on what would be
> better codes to map this to?

Problem is that I do not know when those KEY_PROG keys from 
bios_to_linux_keycode table are emitted. There are missing comments or 
description.

Are you able to find out description for all those keys in that table? 
Maybe now (when linux key constants are extended), there could be better 
candidates...

> I'll double check what the things that "were" mapping to KEY_PROG1
> etc actually were.  This might be a case of an expected clash if the
> functions aren't in current generations.
> 
> >/* Wifi Catcher */
> >
> > { KE_KEY,    0xe011, { KEY_PROG2 } },
> 
> It's worth mentioning that Wifi Catcher hasn't been used for any Dell
> laptops for a handful generations.  The rugged 2in1's are current
> generation that have these programmable buttons and don't have wifi
> catcher.

Anyway, what is "Wifi Catcher"? HW switch buttton which enable/disable 
wifi? Or something else?

> So there should be no "real" clash here.

Problem can be in future. This driver is unified for all Dell products 
with wmi interface and so future product could do some nasty things...

> > But probably we do not have better names...
> 
> In this particular case, I was thinking PROG1/2/3 were really the
> best option and would be most intuitive because the keys really are
> labels "P1" "P2" and "P3".

Probably yes, as I wrote I do not have in my mind better names for now.

> Here's the front of the tablet:
> http://shop-media.intel.com/api/v2/helperservice/getimage?url=http://
> images.icecat.biz/img/norm/high/30031725-706.jpg&height=550&width=550
> 
> > Another small cosmetic change: align WMI codes, so 0x157 and 0x850
> > are at some column (similar like are formatted other actions).
> 
> OK.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)