linux-kernel - Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

Open Source and information security mailing list archives

Message-ID: <8760rrm58e.fsf@free-electrons.com>
Date:	Wed, 27 Jul 2016 18:10:41 +0200
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Grzegorz Jaszczyk <jaz@...ihalf.com>
Cc:	mark.rutland@....com, devicetree@...r.kernel.org,
	jason@...edaemon.net, andrew@...n.ch, linux-kernel@...r.kernel.org,
	linux@...linux.org.uk, alior@...vell.com, robh+dt@...nel.org,
	mw@...ihalf.com, thomas.petazzoni@...e-electrons.com,
	linux-arm-kernel@...ts.infradead.org,
	sebastian.hesselbarth@...il.com
Subject: Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

Hi,

 On mer., juil. 27 2016, Gregory CLEMENT <gregory.clement@...e-electrons.com> wrote:

> Hi Grzegorz,
>  
>  On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@...ihalf.com> wrote:
>
>> Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>
> It looks good:
>
> Acked-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

And here again the title prefix should be change to:
"ARM: dts: mvebu: a385-db-ap:" also do not forget fo add a commit log.

Thanks,

Gregory

>
>> ---
>>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
>> index a18f516..6648a3f 100644
>> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
>> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
>> @@ -182,15 +182,35 @@
>>  
>>  			nfc: flash@...00 {
>>  				status = "okay";
>> -				#address-cells = <1>;
>> -				#size-cells = <1>;
>> -
>>  				num-cs = <1>;
>>  				nand-ecc-strength = <4>;
>>  				nand-ecc-step-size = <512>;
>>  				marvell,nand-keep-config;
>>  				marvell,nand-enable-arbiter;
>>  				nand-on-flash-bbt;
>> +
>> +				partitions {
>> +					compatible = "fixed-partitions";
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
>> +
>> +					partition@0 {
>> +						label = "U-Boot";
>> +						reg = <0x00000000 0x00800000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@...000 {
>> +						label = "uImage";
>> +						reg = <0x00800000 0x00400000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@...000 {
>> +						label = "Root";
>> +						reg = <0x00c00000 0x3f400000>;
>> +					};
>> +				};
>>  			};
>>  
>>  			usb3@...00 {
>> -- 
>> 1.8.3.1
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives