linux-kernel - Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5798ED5C.1020300@intel.com>
Date:	Wed, 27 Jul 2016 10:20:28 -0700
From:	Dave Hansen <dave.hansen@...el.com>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Janani Ravichandran <janani.rvchndrn@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org, riel@...riel.com,
	akpm@...ux-foundation.org, hannes@...pxchg.org,
	vdavydov@...tuozzo.com, mhocko@...e.com, vbabka@...e.cz,
	mgorman@...hsingularity.net, kirill.shutemov@...ux.intel.com,
	bywxiaobai@....com
Subject: Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On 07/27/2016 08:23 AM, Steven Rostedt wrote:
>> > +
>> > +	trace_mm_slowpath_end(page);
>> > +
> I'm thinking you only need one tracepoint, and use function_graph
> tracer for the length of the function call.
> 
>  # cd /sys/kernel/debug/tracing
>  # echo __alloc_pages_nodemask > set_ftrace_filter
>  # echo function_graph > current_tracer
>  # echo 1 > events/kmem/trace_mm_slowpath/enable

I hesitate to endorse using the function_graph tracer for this kind of
stuff.  Tracepoints offer some level of stability in naming, and the
compiler won't ever make them go away.   While __alloc_pages_nodemask is
probably more stable than most things, there's no guarantee that it will
be there.

BTW, what's the overhead of the function graph tracer if the filter is
set up to be really restrictive like above?  Is the overhead really just
limited to that one function?