lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jul 2016 04:11:52 +0100 From: Salah Triki <salah.triki@...il.com> To: akpm@...ux-foundation.org, viro@...IV.linux.org.uk Cc: luisbg@....samsung.com, mhocko@...e.com, vdavydov@...tuozzo.com, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, salah.triki@...il.com Subject: [RESEND PATCH 1/4] fs: befs: Remove redundant validation from befs_find_brun_direct The only caller of befs_find_brun_direct is befs_fblock2brun, which already validates that the block is within the range of direct blocks. So remove the duplicate validation. Signed-off-by: Salah Triki <salah.triki@...il.com> Acked-by: Luis de Bethencourt <luisbg@....samsung.com> --- fs/befs/datastream.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index 26cc417..e224b9a 100644 --- a/fs/befs/datastream.c +++ b/fs/befs/datastream.c @@ -249,17 +249,9 @@ befs_find_brun_direct(struct super_block *sb, const befs_data_stream *data, int i; const befs_block_run *array = data->direct; befs_blocknr_t sum; - befs_blocknr_t max_block = - data->max_direct_range >> BEFS_SB(sb)->block_shift; befs_debug(sb, "---> %s, find %lu", __func__, (unsigned long)blockno); - if (blockno > max_block) { - befs_error(sb, "%s passed block outside of direct region", - __func__); - return BEFS_ERR; - } - for (i = 0, sum = 0; i < BEFS_NUM_DIRECT_BLOCKS; sum += array[i].len, i++) { if (blockno >= sum && blockno < sum + (array[i].len)) { -- 1.9.1
Powered by blists - more mailing lists