linux-kernel - Re: [PATCH 3/3] x86/apic: Clean up the apic delivery mode macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160727222058.GA2595@x1.redhat.com>
Date:	Thu, 28 Jul 2016 06:20:58 +0800
From:	Baoquan He <bhe@...hat.com>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org, x86@...nel.org,
	kexec@...ts.infradead.org, mingo@...hat.com, fenghua.yu@...el.com,
	weijg.fnst@...fujitsu.com, ebiederm@...ssion.com, hpa@...or.com,
	tglx@...utronix.de, vgoyal@...hat.com, jiang.liu@...ux.intel.com
Subject: Re: [PATCH 3/3] x86/apic: Clean up the apic delivery mode macro
 definition

On 07/24/16 at 07:07am, kbuild test robot wrote:
> Hi,


Sorry, I didn't notice this. And after checking code, APIC_DM_EXTINT
could be added for kvm on purpose thought it's not defined in Intel Arch
manual. I am not familiar with KVM, so please drop this patch to avoid
warning. I will make time to study it later.


Thanks
Baoquan

> 
> [auto build test WARNING on iommu/next]
> [also build test WARNING on v4.7-rc7 next-20160722]
> [cannot apply to tip/x86/core]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Baoquan-He/Enable-legacy-irq-mode-before-jump-to-kexec-kdump-kernel/20160724-054857
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
> reproduce:
>         # apt-get install sparse
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    include/linux/compiler.h:232:8: sparse: attribute 'no_sanitize_address': unknown attribute
>    arch/x86/kvm/lapic.c:186:15: sparse: incompatible types in comparison expression (different address spaces)
>    arch/x86/kvm/lapic.c:963:14: sparse: undefined identifier 'APIC_DM_EXTINT'
> >> arch/x86/kvm/lapic.c:963:14: sparse: incompatible types for 'case' statement
>    arch/x86/kvm/lapic.c:699:15: sparse: incompatible types in comparison expression (different address spaces)
>    arch/x86/kvm/lapic.c:799:15: sparse: incompatible types in comparison expression (different address spaces)
>    arch/x86/kvm/lapic.c:963:14: sparse: Expected constant expression in case statement
>    arch/x86/kvm/lapic.c: In function '__apic_accept_irq':
>    arch/x86/kvm/lapic.c:963:7: error: 'APIC_DM_EXTINT' undeclared (first use in this function)
>      case APIC_DM_EXTINT:
>           ^~~~~~~~~~~~~~
>    arch/x86/kvm/lapic.c:963:7: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +/case +963 arch/x86/kvm/lapic.c
> 
> c5ec15340 drivers/kvm/lapic.c  He, Qing        2007-09-03  947  				   vcpu->vcpu_id);
> c5ec15340 drivers/kvm/lapic.c  He, Qing        2007-09-03  948  		}
> 97222cc83 drivers/kvm/lapic.c  Eddie Dong      2007-09-12  949  		break;
> 97222cc83 drivers/kvm/lapic.c  Eddie Dong      2007-09-12  950  
> 97222cc83 drivers/kvm/lapic.c  Eddie Dong      2007-09-12  951  	case APIC_DM_STARTUP:
> 1b10bf31a arch/x86/kvm/lapic.c Jan Kiszka      2008-09-30  952  		apic_debug("SIPI to vcpu %d vector 0x%02x\n",
> c5ec15340 drivers/kvm/lapic.c  He, Qing        2007-09-03  953  			   vcpu->vcpu_id, vector);
> 6da7e3f64 arch/x86/kvm/lapic.c Gleb Natapov    2009-03-05  954  		result = 1;
> 66450a21f arch/x86/kvm/lapic.c Jan Kiszka      2013-03-13  955  		apic->sipi_vector = vector;
> 66450a21f arch/x86/kvm/lapic.c Jan Kiszka      2013-03-13  956  		/* make sure sipi_vector is visible for the receiver */
> 66450a21f arch/x86/kvm/lapic.c Jan Kiszka      2013-03-13  957  		smp_wmb();
> 66450a21f arch/x86/kvm/lapic.c Jan Kiszka      2013-03-13  958  		set_bit(KVM_APIC_SIPI, &apic->pending_events);
> 3842d135f arch/x86/kvm/lapic.c Avi Kivity      2010-07-27  959  		kvm_make_request(KVM_REQ_EVENT, vcpu);
> d76901750 arch/x86/kvm/lapic.c Marcelo Tosatti 2008-09-08  960  		kvm_vcpu_kick(vcpu);
> 97222cc83 drivers/kvm/lapic.c  Eddie Dong      2007-09-12  961  		break;
> 97222cc83 drivers/kvm/lapic.c  Eddie Dong      2007-09-12  962  
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26 @963  	case APIC_DM_EXTINT:
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  964  		/*
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  965  		 * Should only be called by kvm_apic_local_deliver() with LVT0,
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  966  		 * before NMI watchdog was enabled. Already handled by
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  967  		 * kvm_apic_accept_pic_intr().
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  968  		 */
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  969  		break;
> 23930f952 arch/x86/kvm/lapic.c Jan Kiszka      2008-09-26  970  
> 97222cc83 drivers/kvm/lapic.c  Eddie Dong      2007-09-12  971  	default:
> 
> :::::: The code at line 963 was first introduced by commit
> :::::: 23930f9521c9c4d4aa96cdb9d1e1703f3782bb94 KVM: x86: Enable NMI Watchdog via in-kernel PIT source
> 
> :::::: TO: Jan Kiszka <jan.kiszka@...mens.com>
> :::::: CC: Avi Kivity <avi@...hat.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation