linux-kernel - Re: [PATCH] pnpbios: add header file to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2367158.Y693rAZPTH@vostro.rjw.lan>
Date:	Thu, 28 Jul 2016 01:49:55 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] pnpbios: add header file to fix build errors

On Tuesday, July 26, 2016 04:26:40 PM Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors due to missing header file:
> 
> ../drivers/pnp/pnpbios/core.c: In function 'pnp_dock_event':
> ../drivers/pnp/pnpbios/core.c:141:2: error: implicit declaration of function 'call_usermodehelper' [-Werror=implicit-function-declaration]
>   value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
>   ^
> ../drivers/pnp/pnpbios/core.c:141:52: error: 'UMH_WAIT_EXEC' undeclared (first use in this function)
>   value = call_usermodehelper(argv [0], argv, envp, UMH_WAIT_EXEC);
>                                                     ^
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> I should have copied Rafael on this the first time.
> Also applies to mainline.

OK, I'm going to apply it, thanks!

>  drivers/pnp/pnpbios/core.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20160711.orig/drivers/pnp/pnpbios/core.c
> +++ linux-next-20160711/drivers/pnp/pnpbios/core.c
> @@ -60,6 +60,7 @@
>  #include <linux/delay.h>
>  #include <linux/acpi.h>
>  #include <linux/freezer.h>
> +#include <linux/kmod.h>
>  #include <linux/kthread.h>
>  
>  #include <asm/page.h>

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.