linux-kernel - RE: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <757384616.167210.1469593665960.JavaMail.weblogic@ep1ml101a>
Date:	Wed, 27 Jul 2016 04:27:45 +0000
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>,
	linux-kernel@...r.kernel.org 
	<linux-kernel@...r.kernel.org>
Cc:	zyw@...k-chips.com <zyw@...k-chips.com>,
	groeck@...omium.org <groeck@...omium.org>,
	cwchoi00@...il.com <cwchoi00@...il.com>
Subject: RE: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

> This patch adds the new extcon type to group the each connecotr
> into following five category. This type would be used to handle
> the connectors as a group unit instead of a connector unit.
> - EXTCON_TYPE_USB  : USB connector
> - EXTCON_TYPE_CHG  : Charger connector
> - EXTCON_TYPE_JACK : Jack connector

"Jack" seems to be an internal jargon that many people won't recognize.
It's, in fact, 3.5-pi, isn't it?

Anyway, this is already being used as an enum with drivers,
I'd suggest to add a comment in extcon.h stating that 
"Jack connector" is usually the 3.5-pi earbud connector.

Anyway, I like the direction of this patch.


Signed-off-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Cheers,
MyungJoo

> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -29,6 +29,15 @@
>  #include <linux/device.h>
>  
>  /*
> + * Define the type of supported external connectors
> + */
> +#define EXTCON_TYPE_USB		BIT(0)	/* USB connector */
> +#define EXTCON_TYPE_CHG		BIT(1)	/* Charger connector */
> +#define EXTCON_TYPE_JACK	BIT(2)	/* Jack connector */
+                                /* Usually, this is a 3.5-pi earbud conector */
> +#define EXTCON_TYPE_DISP	BIT(3)	/* Display connector */
> +#define EXTCON_TYPE_MISC	BIT(4)	/* Miscellaneous connector */
> +
> +/*
>   * Define the unique id of supported external connectors
>   */
>  #define EXTCON_NONE		0
> -- 
> 1.9.1
>