linux-kernel - Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160727051909.GC75806@f23x64.localdomain>
Date:	Tue, 26 Jul 2016 22:19:09 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Mario Limonciello <mario_limonciello@...l.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org,
	Pali Rohár <pali.rohar@...il.com>
Subject: Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s

On Fri, Jul 22, 2016 at 03:01:24PM -0500, Mario Limonciello wrote:
> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
> and a detachable magnetic keyboard/mouse.
> 
> Signed-off-by: Mario Limonciello <mario_limonciello@...l.com>

+Pali

Pali, any concerns?

> ---
>  drivers/platform/x86/dell-wmi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 15c6f11..6ba42d0 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -222,6 +222,16 @@ static const struct key_entry dell_wmi_extra_keymap[] __initconst = {
>  
>  	/* Stealth mode toggle */
>  	{ KE_IGNORE, 0x155, { KEY_RESERVED } },
> +
> +	/* Rugged magnetic keyboard/mouse events */
> +	{ KE_IGNORE, 0x156, { KEY_RESERVED } },
> +	{ KE_IGNORE, 0x157, { KEY_RESERVED } },
> +
> +	/* Rugged programmable (P1/P2/P3 keys) */
> +	{ KE_KEY, 0x850, { KEY_PROG1 } },
> +	{ KE_KEY, 0x851, { KEY_PROG2 } },
> +	{ KE_KEY, 0x852, { KEY_PROG3 } },
> +
>  };
>  
>  static struct input_dev *dell_wmi_input_dev;
> -- 
> 2.7.4
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center